Uploaded solutions to all exercises#6
Open
ckkok wants to merge 3 commits intoawongh:masterfrom
ckkok:master
Open
Uploaded solutions to all exercises#6ckkok wants to merge 3 commits intoawongh:masterfrom ckkok:master
ckkok wants to merge 3 commits intoawongh:masterfrom
ckkok:master
Conversation
ckkok
changed the title
ckkok
commented
Feb 27, 2018
| // We can of course shift the binary string beforehand to account for this, but *lazy*. Edit: Ah | ||
| // heck it, I wrote that thing above. | ||
|
|
||
| // Need to either shift the binary filter to the right by 2 digits to prepare for the next iteration, or to reset it if it's done. |
Author
There was a problem hiding this comment.
(I'm checking out this discussion function of GitHub... I've never used this before. Seems a bit messy D:)
Note: This explanation needs to be better phrased. The | isn't conventionally referred to by the "or reset the ..." phrase. What it's doing is 3 bitwise operators, shift to the right by 2, then bitwise-OR with the previous result shifted left by 28 (effectively returning the current 2-digit binary filter to all the way to the left for use later).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deliverable Submission
Please describe your comfort and completeness levels before submitting.
Comfort Level (1-5): 5
Completeness Level (1-5): 5
What did you think of this deliverable?:
Nice opportunity to practise JS. It's been a while :D