feat(instance): improve instance resource handling and updates #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test ec2-kind-e2e |
michaelhtm
force-pushed
the
feat/supportinstanceupdates
branch
from
3c9182e to
a77e1ad
Compare
|
/test ec2-unit-test |
michaelhtm
force-pushed
the
feat/supportinstanceupdates
branch
from
a77e1ad to
60d4776
Compare
|
/test ec2-kind-e2e |
|
/retest |
- Add InvalidInstanceID.NotFound error code for 404 exceptions - Implement instance state handling and requeue logic - Add support for modifying instance attributes (security groups, API termination, etc.) - Add helper functions for instance state checks and field updates - Update E2E tests to verify instance updates and security group modifications - Set additional fields like SecurityGroupIDs and Monitoring in instance spec - Improve instance syncing and status conditions This commit enhances the EC2 instance resource controller by adding better error handling, state management, and support for modifying various instance attributes. It also includes improvements to E2E tests and resource syncing.
michaelhtm
force-pushed
the
feat/supportinstanceupdates
branch
from
60d4776 to
6973e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1709
Description of changes:
This commit enhances the EC2 instance resource controller by adding better error handling,
state management, and support for modifying various instance attributes. It also includes
improvements to E2E tests and resource syncing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.