Skip to content

Ensure RabbitMQ Broker reaches synced status when using non-default security group #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 2, 2025
Merged

Ensure RabbitMQ Broker reaches synced status when using non-default security group #104

merged 10 commits into from
Oct 2, 2025

Conversation

knottnt
Copy link
Contributor

@knottnt knottnt commented Sep 16, 2025

Issue #, if available:

Description of changes:

  • Add .vscode to .gitignore
  • Omit unchanged field from update payload
  • Only set spec fields included in delta in sdkUpdate
  • late initialize fields to load default values after broker creation
  • Add delta pre-compare hook to match EngineVersion by prefix instead of exact match
  • Add e2e test validating creation of RabbitMQ broker with non-default security group becomes synced
  • Add tests for delta comparison of EngineVersion
  • Update create/delete e2e test to validate update behavior

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ack-prow ack-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2025
@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 September 16, 2025 01:17
@ack-prow ack-prow bot added the approved label Sep 16, 2025
knottnt
knottnt commented Sep 16, 2025
View reviewed changes
@knottnt knottnt mentioned this pull request Sep 16, 2025
Merged
@knottnt
Copy link
Contributor Author

knottnt commented Sep 16, 2025

/test all

1 similar comment
@knottnt
Copy link
Contributor Author

knottnt commented Sep 18, 2025

/test all

@knottnt
Avoid sending unnecessary fields in UpdateBroker call
2459edf 
- Add .vscode to .gitignore
- Enable late_initialize for fields not set by the Create API's response
- Set omit_unchanged_fields to true
- Set only_set_unchanged_fields to true
@knottnt
Only compare EngineVersion by prefix
e5cc9c7 
- Add custom hook to check that latest EngineVersion has Spec.EngineVersion as prefix instead of checking for exact match.
@knottnt
Ensure that Broker is synced in E2E test
e28fbc2
@knottnt
Add e2e test for RabbitMQ with non-default sg
2041f1e 
- Add e2e test to ensure that the ACK resource syncs when creating a RabbitMQ broker with a non-default security group
@knottnt
Test engine comparison logic
fac0f5a
@knottnt
Update created/delete e2e test to verify update
a8ed1c8 
- Move creation of broker to fixture
- Add test logic for validating update of broker
@knottnt
Fix naming of test resource
d42701a
@knottnt
Copy link
Contributor Author

knottnt commented Sep 24, 2025

/test mq-kind-e2e

@knottnt knottnt force-pushed the rabbitmq-security-groups branch from 7dcabd0 to 402a132 Compare September 25, 2025 03:52
@knottnt
Copy link
Contributor Author

knottnt commented Sep 25, 2025

/test all

@knottnt knottnt marked this pull request as ready for review September 25, 2025 04:08
@ack-prow ack-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2025
@ack-prow ack-prow bot requested a review from a-hilaly September 25, 2025 04:08
@knottnt
Copy link
Contributor Author

knottnt commented Sep 26, 2025

/hold
for code-gen change to be merged.

@ack-prow ack-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2025
michaelhtm
michaelhtm reviewed Sep 26, 2025
View reviewed changes
michaelhtm
michaelhtm reviewed Sep 26, 2025
View reviewed changes
@knottnt
Update delta_test.go
73f4c60 
- Add test case for delta when engine version differs by patch version
@knottnt knottnt requested a review from michaelhtm September 26, 2025 20:07
@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 29, 2025

@knottnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
mq-verify-attribution 40da041 link false /test mq-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link
Contributor Author

knottnt commented Sep 29, 2025

/unhold

@ack-prow ack-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2025
michaelhtm
michaelhtm approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 0c20009 into aws-controllers-k8s:main Oct 2, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhtm michaelhtm michaelhtm approved these changes

@rushmash91 rushmash91 Awaiting requested review from rushmash91

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

Assignees

@michaelhtm michaelhtm

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knottnt @michaelhtm