Skip to content

feat: add require_approval flag to reusable release workflows #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crowecawcaw wants to merge 1 commit into from
Closed

feat: add require_approval flag to reusable release workflows #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/reusable_build_and_stage_installers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
project_name:
required: true
type: string
require_approval:
required: false
type: boolean
default: true

jobs:
BuildInstallers:
Expand All @@ -28,7 +32,7 @@ jobs:
StageBuiltInstallers:
needs: BuildInstallers
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
strategy:
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/reusable_bump.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@ on:
force_version_bump:
required: false
default: ""
type: string
type: string
require_approval:
required: false
type: boolean
default: true

jobs:
Bump:
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
contents: write
pull-requests: write
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/reusable_prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@ on:
tag:
required: true
type: string
require_approval:
required: false
type: boolean
default: true


jobs:
PreRelease:
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
contents: write
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/reusable_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ name: 'Publish'

on:
workflow_call:
inputs:
require_approval:
required: false
type: boolean
default: true

jobs:
VerifyCommit:
Expand Down Expand Up @@ -29,7 +34,7 @@ jobs:
Release:
needs: VerifyCommit
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
contents: write
Expand Down Expand Up @@ -158,7 +163,7 @@ jobs:
PublishToInternal:
needs: Release
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
steps:
Expand All @@ -178,7 +183,7 @@ jobs:
PublishToRepository:
needs: PublishToInternal
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
contents: read
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/reusable_publish_python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,15 @@ on:
tag:
required: true
type: string

require_approval:
required: false
type: boolean
default: true

jobs:
PublishToCodeArtifact:
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
steps:
Expand Down
16 changes: 10 additions & 6 deletions .github/workflows/reusable_publish_v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ on:
installer_oses:
required: false
type: string
require_approval:
required: false
type: boolean
default: true
outputs:
tag:
description: "The newly created tag"
Expand Down Expand Up @@ -59,7 +63,7 @@ jobs:
PreRelease:
needs: UnitTests
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
outputs:
tag: ${{steps.prep-release.outputs.TAG}}
permissions:
Expand Down Expand Up @@ -147,7 +151,7 @@ jobs:
needs: BuildInstallers
if: needs.BuildInstallers.result == 'success' || needs.BuildInstallers.result == 'skipped'
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
name: “Is the Conda Package available in all ProdWaves and have you ran any required manual tests?”
steps:
- run: |
Expand All @@ -161,7 +165,7 @@ jobs:
permissions:
id-token: write
contents: write
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
env:
TAG: ${{needs.PreRelease.outputs.tag}}
steps:
Expand Down Expand Up @@ -219,7 +223,7 @@ jobs:
ReleaseBuiltInstallers:
needs: [Release, PreRelease]
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
if: (needs.Release.result == 'success' && needs.PreRelease.result == 'success') && ${{ inputs.installer_oses }}
permissions:
id-token: write
Expand Down Expand Up @@ -251,7 +255,7 @@ jobs:
needs: [ReleaseBuiltInstallers, PreRelease]
if: (needs.ReleaseBuiltInstallers.result == 'success' && needs.PreRelease.result == 'success')
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
env:
Expand All @@ -275,7 +279,7 @@ jobs:
needs: [PublishToInternal, PreRelease]
if: (needs.PublishToInternal.result == 'success' && needs.PreRelease.result == 'success')
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
contents: read
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/reusable_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
tag:
required: true
type: string
require_approval:
required: false
type: boolean
default: true


jobs:
Expand All @@ -15,7 +19,7 @@ jobs:
permissions:
id-token: write
contents: write
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/reusable_release_installers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,15 @@ on:
project_name:
required: true
type: string
require_approval:
required: false
type: boolean
default: true

jobs:
ReleaseInstaller:
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
permissions:
id-token: write
strategy:
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/reusable_tag_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ on:
required: false
type: string
description: "Existing tag to use (optional)"
require_approval:
required: false
type: boolean
default: true
outputs:
tag:
description: "The validated tag"
Expand All @@ -19,7 +23,7 @@ on:
jobs:
TagRelease:
runs-on: ubuntu-latest
environment: release
environment: ${{ inputs.require_approval && 'release' || 'release-no-approval-required' }}
outputs:
tag: ${{ steps.tag-release.outputs.tag }}
steps:
Expand Down
Loading