Skip to content

feat: Notify customers if newer submitter is available.#295

Merged
karthikbekalp merged 1 commit intoaws-deadline:mainlinefrom
karthikbekalp:updateDialogp3
Apr 21, 2026
Merged

feat: Notify customers if newer submitter is available.#295
karthikbekalp merged 1 commit intoaws-deadline:mainlinefrom
karthikbekalp:updateDialogp3

Conversation

@karthikbekalp
Copy link
Copy Markdown
Contributor

@karthikbekalp karthikbekalp commented Apr 3, 2026

What was the problem/requirement? (What/Why)

Customers did not know whether they were on the latest submitter or not. This means they would not have the latest bug fixes or features to work with our product.

This is based off a similar PR for Cinema 4D: aws-deadline/deadline-cloud-for-cinema-4d#414

What was the solution? (How)

Depends on: aws-deadline/deadline-cloud#1070

This adds a dialog which checks our download manifests and if there's a new update available notifies customer that.

image

What is the impact of this change?

How was this change tested?

Here's the test cases that I manually tested in Nuke on Windows:

# Test Case Steps Expected Result Pass?
Config GUI — setting visible
1 Setting in config GUI Open Nuke → AWS Deadline Cloud → Submit to Deadline Cloud "Show submitter update notifications" checkbox is visible YES
Config disabled — no dialog
2 Notification disabled via GUI Uncheck "Show submitter update notifications" → Apply → close & reopen submitter No network call, no dialog, submitter opens normally YES
Config enabled, no internet — graceful failure
3 Re-enable notification via GUI Check "Show submitter update notifications" → Apply Setting updated YES
4 No internet / firewall Disconnect network → open submitter Submitter opens normally, no crash, no visible error YES
Config enabled, internet available, no update
5 Current == latest Restore network, ensure installed version matches manifest No dialog, submitter opens normally YES
6 Current > latest (dev build) Install a version newer than manifest No dialog, submitter opens normally YES
Config enabled, internet available, update exists
7 Current < latest Install an older version than manifest Update dialog appears YES
8 Dialog content Inspect the dialog Shows "Nuke", correct current & latest versions YES
9 Dialog layout Resize / check Min width 400px, text wraps properly YES
10 Dialog timing Observe launch order Dialog appears before Cinema4D submitter window YES
Dialog interactions — Dismiss
11 Click "Dismiss" Click Dismiss button Dialog closes, submitter opens normally YES
12 Close via X Click X button on dialog Dialog closes, submitter opens normally YES
Dialog interactions — Download
13 Click "View release notes" Click the link Nuke GitHub releases page opens in browser YES
14 Click "Download" Click Download button Correct installer URL opens in browser YES
15 Restart reminder After Download click "Application Restart Required" info box appears YES
Edge cases
16 Non-standard _version.py tuple Modify version tuple No crash YES
17 Click "Don't remind me again" Will dismiss and also never show the dialog again No crash YES
18 Click "Dismiss" Does not show the dialog again for the session No crash YES

Please run the integration tests and paste the results below

WIP (Trying to figure out how to run the integration tests)

If installer/ was modified or a file was added/removed from src/, then update the installer tests and post the test results below

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Required: paste the contents of job_bundle_output_tests/test-job-bundle-results.txt here

Was this change documented?

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@karthikbekalp karthikbekalp requested a review from a team as a code owner April 3, 2026 22:06
@karthikbekalp karthikbekalp marked this pull request as draft April 3, 2026 22:06
@github-actions github-actions Bot added the waiting-on-maintainers Waiting on the maintainers to review. label Apr 3, 2026
@npmacl npmacl removed the waiting-on-maintainers Waiting on the maintainers to review. label Apr 6, 2026
@npmacl
Copy link
Copy Markdown
Contributor

npmacl commented Apr 6, 2026

We talked on slack about possibly making it so that after clicking "Dismiss", the popup wont appear again until the user reopens nuke.

Comment thread src/deadline/nuke_submitter/update_utils.py Fixed
@karthikbekalp karthikbekalp force-pushed the updateDialogp3 branch 3 times, most recently from 973518b to 2b5453f Compare April 15, 2026 19:24
@karthikbekalp karthikbekalp marked this pull request as ready for review April 15, 2026 19:25
@karthikbekalp karthikbekalp enabled auto-merge (squash) April 15, 2026 19:25
Comment thread pyproject.toml

dependencies = [
"deadline >= 0.49,< 0.56",
"deadline >= 0.55.1,< 0.56",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required for the new config changes.

Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@karthikbekalp karthikbekalp merged commit 2f1daf1 into aws-deadline:mainline Apr 21, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants