Initial prototype for prefabs-dpe integration#476
Draft
srikappa-amzn wants to merge 8 commits intodevelopmentfrom
Draft
Initial prototype for prefabs-dpe integration#476srikappa-amzn wants to merge 8 commits intodevelopmentfrom
srikappa-amzn wants to merge 8 commits intodevelopmentfrom
Conversation
Idea is simple: 1. If non-opaque value, simply convert AZ::Dom::Value to PrefabDomValue 2. If opaque value, get its void* and serialize the value 3. In either of the above cases, modify dpe-dompath to prefab-dompath by reading in the 'SerializedPath' information stored in property editor nodes Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
srikappa-amzn
requested review from
NicholasVanSickle,
alexmontAmazon,
amzn-tmryan,
dtamkin1 and
nick-l-o3de
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
…g them as opaque values Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
…otype Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
…otype Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
Signed-off-by: srikappa-amzn <82230713+srikappa-amzn@users.noreply.github.com>
antonmic
added a commit
that referenced
this pull request
Jun 15, 2023
…gUnusedPasses Removing unused passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea is simple:
The crux of the logic is in GeneratePropertyEditPatch() which stops at producing rapidjson patches to be used by the prefab system. This code doesn't yet use these patches. But I've validated that the patches generated are valid manually. I've tested it with a few components (the ones under Atom default environment that comes with every level) and so far it seems to hold its ground and produce valid patches with all those components
Signed-off-by: srikappa-amzn 82230713+srikappa-amzn@users.noreply.github.com