Replace RDS password-based authentication with IAM role authentication #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Python Django app to use IAM role auth instead of base64 decoded password Updated Java Spring Boot app to use IAM role auth with useAWSIam=true parameter Updated Node.js app to use IAM role auth with SSL configuration Removed RDS_MYSQL_CLUSTER_PASSWORD environment variables from all Terraform configurations Removed password-related variables from Terraform variable files All applications now use IAM role authentication for RDS connections
lukeina2z
force-pushed
the
rds-pwd-fix
branch
from
ed60c3e to
4dffcbb
Compare
lukeina2z
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
MySQL user password is used to connect to MySQL hosted on AWS RDS.
Description of changes:
Removed the RDS database connection string environment variable from the Java sample app. Now all sample apps behave consistently; They use the same four environment variables to connect to MySQL without requiring a MySQL user password.
AWS_REGION
RDS_MYSQL_CLUSTER_ENDPOINT
RDS_MYSQL_CLUSTER_DATABASE
RDS_MYSQL_CLUSTER_USERNAME
Rollback procedure:
Revert this PR, rebuild and redeploy these testing apps.
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Yes.
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.ymlfile withname: Testand workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2e2e-playgroundin us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.