This repository was archived by the owner on Nov 1, 2023. It is now read-only.
fix parameter checking for domain name/hosted id zone #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the parameter checking is such that when no hosted id zone is present, the stack will fail when the domain name is also not present. the same is true in the reverse direction: when no domain name is specified, the stack fails if no hosted id zone is present. this change fixes the checks such that the assertions only come into play when the initial field *is* present. for example, if the hosted id zone *is* present, then the domain name must also be present. similarly, when the domain name is present, the hosted id zone must also be.
|
Thanks for the input, I will test this out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the parameter checking is such that when no hosted id zone is present,
the stack will fail when the domain name is also not present. the same
is true in the reverse direction: when no domain name is specified, the
stack fails if no hosted id zone is present.
this change fixes the checks such that the assertions only come into
play when the initial field is present. for example, if the
hosted id zone is present, then the domain name must also be present.
similarly, when the domain name is present, the hosted id zone must
also be.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.