Fix closed network subnet selection #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tbrand wants to merge 1 commit into main from closed-fix-subnets

+8 −10

Contributor

tbrand commented Oct 1, 2025

Description of Changes

props.vpc.selectSubnets()で、SubnetFilter.byIds(props.subnetIds)を使ってサブネットをフィルタしている
しかし、props.vpcはec2.Vpc.fromLookup()で取得された既存VPCの参照
CDKのfromLookup()では、指定されたサブネットIDの詳細情報（AZ情報など）が正しく解決されない場合がある
結果としてsubnets配列が空になり、58行目のif (ipAddresses.length < 2)でエラーが発生

Checklist

Modified relevant documentation
Verified operation in local environment
Executed npm run cdk:test and if there are snapshot differences, execute npm run cdk:test:update-snapshot to update snapshots

Related Issues

fix

9065c54

tbrand mentioned this pull request

閉域モードでサブネットを指定してデプロイしたがエラーになる。 #1295

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet