Fix integ tests for EKS addon version > 6.x#379
Open
mitali-salvi wants to merge 4 commits intomainfrom
Open
Conversation
Update resource counts and validations to match the OTLP Container Insights components added in helm-chart 6.x: - Add kube-state-metrics, node-exporter, cluster-scraper resources - Update service/daemonset/pod counts for new components - Add OTLP CI RBAC validations (SAs, roles, bindings) - Add cloudwatch-agent-role to Roles and RoleBindings validation - Replace fmt.Println with t.Logf for proper test logging - Use named daemonSetNameRegex constant instead of inline regex
The previous default v1.1.0-eksbuild.1 is no longer a supported addon version, causing all integration tests to fail with InvalidParameterException before any Go tests could run.
The v6.0.1 EKS addon does not create cloudwatch-agent-role as a namespace-scoped Role or cloudwatch-agent-role-binding as a namespace-scoped RoleBinding. These only exist as ClusterRole and ClusterRoleBinding which are already validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Integration tests are failing due to a change in the number of resources generated by the EKS addon for version > 6.x due to the addition of additional components to support OTel container insights -
https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/25129725219
This PR fixes those discrepancies in resources created by the EKS addon
Test run post fixing - https://github.com/aws/amazon-cloudwatch-agent-operator/actions/runs/25178745653
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.