[v2] add flag to prevent overwriting existing objects in S3 high level commands #9750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated s3Transfer manager generating original version Updated args list updated transfer manager for upload
Removed unwanted comments for test
Implemented No-overwrite for uploads using cp command
Adding Warning handler for no_overwrite
handled error during download streaming streaming
Updated test case Updated doc comment Added test cases Updating Sync Strategy Updated comments Updated comments Override sync strategy Overridding sync strategy
Added no overwrite for download operation handled error during download streaming streaming Improved upload test cases Updated test cases Added test cases Resolved requested changes NIT change
…tion Implementing no-overwrite for sync and download
…sult (fix printing bugs when using no-overwrite flag) (#9717) Fixed bug when using `--no-overwrite` parameter where the last character printed to CLI would be a carriage return, which would cause incompatibility with some terminal program. * Keep track of files skipped. * Update files remaining progress computation to take into account files skipped. * Add support for results that do not print newlines via SkipFileResult and updates to ResultPrinter.
[no overwrite] Merge in v2 to s3-no-overwrite
This commit rolls back changes made to force multipart copies if no overwrite is specified. This includes checking for 0-length files. It also removes the CopyObject argument block list, since IfNoneMatch is now allowed and was the only argument in the list. It also removes the tests for 0 length files and moves some tests to the TestNonMultipartCopy class, since CopyObject accepts IfNoneMatch and no longer needs to force multipart copying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.