Extract mode specific display into DisplayStrategy #9923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aemous
requested changes
Dec 16, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
some questions, and very minor change(s) requested
tests/unit/customizations/ecs/expressgateway/test_display_strategy.py
Outdated
Show resolved
Hide resolved
tests/unit/customizations/ecs/expressgateway/test_display_strategy.py
Outdated
Show resolved
Hide resolved
aemous
reviewed
Dec 16, 2025
aemous
reviewed
Dec 16, 2025
aemous
reviewed
Dec 16, 2025
jutyler1
commented
Dec 16, 2025
Author
jutyler1
left a comment
jutyler1
left a comment
There was a problem hiding this comment.
also fixed a method name inconsistency
aemous
approved these changes
Dec 16, 2025
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
LGTM. Thanks for adding the new test for verifying the display is closed.
aemous
merged commit ae43a41
into
aws:ecs-express-gateway-text-only
44 of 45 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Extract mode specific display into DisplayStrategy.
This should be no-op. A new strategy/mode will be added next comit
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.