refactor: Use Duration dataclass #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change Duration.seconds(5) to Duration.from_seconds(5) - Aligns with Duration refactoring in main SDK
ghost
closed this
ghost
reopened this
ghost
closed this
ghost
reopened this
- Replace context.wait(seconds=N) with context.wait(Duration.from_seconds(N)) - Replace CallbackConfig(timeout_seconds=N) with CallbackConfig(timeout=Duration.from_seconds(N)) - Replace WaitForCallbackConfig timeout_seconds/heartbeat_timeout_seconds with Duration objects - Replace RetryStrategyConfig initial_delay_seconds/max_delay_seconds with Duration objects - Add Duration import to all affected files - Aligns with Duration refactoring in main SDK
ghost
force-pushed
the
duration-struct
branch
from
9cd1957 to
0ada51c
Compare
ghost
closed this
ghost
reopened this
ghost
closed this
ghost
reopened this
ghost
changed the title
ghost
closed this
ghost
reopened this
ghost
changed the title
ghost
closed this
ghost
reopened this
ghost
force-pushed
the
duration-struct
branch
from
30d0b16 to
0ada51c
Compare
Contributor
|
oops I also refactored the tests (with some new tests) in #105 |
Author
|
Okay let's close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON_LANGUAGE_SDK_BRANCH: use-duration