Skip to content

chore(CI): migrate CB CI jobs to GHA #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 3, 2025

Conversation

josecorella
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@josecorella josecorella closed this Jul 2, 2025
@josecorella josecorella reopened this Jul 2, 2025
@josecorella josecorella marked this pull request as ready for review July 2, 2025 22:24
@josecorella josecorella requested a review from a team as a code owner July 2, 2025 22:24
cfn.yml Outdated
@@ -0,0 +1,54 @@
AWSTemplateFormatVersion: "2010-09-09"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have CFN for this repo: https://github.com/aws/aws-dynamodb-encryption-python/blob/master/cfn/CB.yml

Should we just add it there? (and/or refactor since it's called CB.yml but I don't care about that)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep them separate for now since the CB.yml has the infra for the release projects and this poorly named file is only to create a role

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Could this file go in the cfn/ folder though?

josecorella and others added 2 commits July 2, 2025 15:30
Co-authored-by: Lucas McDonald <lucasmcdonald3@gmail.com>
@josecorella josecorella merged commit 1d3a84b into master Jul 3, 2025
75 checks passed
@josecorella josecorella deleted the jocorell/move-cb-ci-jobs-to-gha branch July 3, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants