Skip to content

chore: fix version leakage in esdk release #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josecorella merged 2 commits into from
Mar 24, 2026
Merged

chore: fix version leakage in esdk release #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6ad296
chore: fix version leakage in esdk release
josecorella Mar 24, 2026
afa939b
m
josecorella Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AwsEncryptionSDK/codebuild/release/release-prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ phases:
commands:
- mkdir build
- export VERSION=`grep '<Version>' runtimes/net/ESDK.csproj | sed 's/.*<Version>\(.*\)<\/Version>/\1/'`
- dotnet pack runtimes/net/ESDK.csproj --no-build /p:Configuration=Release,Version=$VERSION --output build
- dotnet pack runtimes/net/ESDK.csproj --no-build /p:Configuration=Release --output build
- export API_ACCESS_KEY=$(python $BASE/retrieve_api_access_key.py)
- dotnet nuget push build/AWS.Cryptography.EncryptionSDK.$VERSION.nupkg --api-key "$API_ACCESS_KEY" --source https://api.nuget.org/v3/index.json
2 changes: 1 addition & 1 deletion AwsEncryptionSDK/codebuild/release/release-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ phases:
# Set a unique version for releasing to staging, because this may fail and we don't
# want to collide with previous runs
- export VERSION=`grep '<Version>' runtimes/net/ESDK.csproj | sed 's/.*<Version>\(.*\)<\/Version>/\1/'`
- dotnet pack runtimes/net/ESDK.csproj --no-build /p:Configuration=Release,Version=$VERSION --output build
- dotnet pack runtimes/net/ESDK.csproj --no-build /p:Configuration=Release --output build
- dotnet nuget push build/AWS.Cryptography.EncryptionSDK.$VERSION.nupkg --source crypto-tools-internal/esdk-net-staging
# Now validate we can run examples
- sed -i.backup "/\<ProjectReference Include=\"..\/ESDK.csproj\" \/>/d" runtimes/net/tests/Test-ESDK.csproj
Expand Down
30 changes: 15 additions & 15 deletions AwsEncryptionSDK/codebuild/release/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,18 @@ batch:
image: aws/codebuild/standard:6.0
depend-on:
- sign
- identifier: release_prod
buildspec: AwsEncryptionSDK/codebuild/release/release-prod.yml
env:
type: LINUX_CONTAINER
image: aws/codebuild/standard:6.0
depend-on:
- verify
- release_staging
- identifier: test_prod
buildspec: AwsEncryptionSDK/codebuild/release/test-prod.yml
env:
type: LINUX_CONTAINER
image: aws/codebuild/standard:6.0
depend-on:
- release_prod
#- identifier: release_prod
# buildspec: AwsEncryptionSDK/codebuild/release/release-prod.yml
# env:
# type: LINUX_CONTAINER
# image: aws/codebuild/standard:6.0
# depend-on:
# - verify
# - release_staging
#- identifier: test_prod
# buildspec: AwsEncryptionSDK/codebuild/release/test-prod.yml
# env:
# type: LINUX_CONTAINER
# image: aws/codebuild/standard:6.0
# depend-on:
# - release_prod
Loading