Skip to content

chore(rust): run clippy on CI and allow large error for Clippy #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishav-karanjit merged 2 commits into from
Apr 1, 2026
+9 −1
Merged

chore(rust): run clippy on CI and allow large error for Clippy #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd27d33
m
rishav-karanjit Mar 31, 2026
cd6bf8e
ignore large error linter failure as MPL returns large errors
rishav-karanjit Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/library_rust_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
- name: Setup Rust Toolchain for GitHub CI
uses: actions-rust-lang/setup-rust-toolchain@v1
with:
components: rustfmt
components: rustfmt, clippy

- name: Setup Dafny
uses: ./mpl/.github/actions/setup_dafny
Expand Down Expand Up @@ -94,6 +94,13 @@ jobs:
CORES=$(node -e 'console.log(os.cpus().length)')
make transpile_rust CORES=$CORES

- name: Run clippy
working-directory: ${{ matrix.library }}/runtimes/rust
shell: bash
run: |
cargo clippy
cargo clippy --example main

- name: Test Rust
working-directory: ${{ matrix.library }}
shell: bash
Expand Down
1 change: 1 addition & 0 deletions AwsEncryptionSDK/runtimes/rust/examples/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#![deny(warnings, unconditional_panic)]
#![deny(nonstandard_style)]
#![deny(clippy::all)]
#![allow(clippy::result_large_err)]

pub mod client_supplier;
pub mod cryptographic_materials_manager;
Expand Down
Loading