-
Notifications
You must be signed in to change notification settings - Fork 25
chore(rust): release v1.2.4 #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43767,7 +43767,7 @@ pub mod software { | |
| } | ||
| /// ../mpl/ComAmazonawsKms/src/Index.dfy(31,3) | ||
| pub fn DafnyUserAgentSuffix(runtime: &Sequence<DafnyCharUTF16>) -> Sequence<DafnyCharUTF16> { | ||
| let mut version: Sequence<DafnyCharUTF16> = string_utf16_of("1.11.0"); | ||
| let mut version: Sequence<DafnyCharUTF16> = string_utf16_of("2.0.0"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't this be 1.2.4?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is dafny generated code, we only put same value here for all runtime. The release readme does not tell me to update this manually. If we use this version value, then I can update the release readme to say to manually update this. But, if there is no use case for the version value then we can leave it as-is as I prefer less manual changes possible while doing the release.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. got it. that's unfortunate since it makes no sense why the 1.2.4 release will make calls to kms with a 2.0.0 or 1.11.0 useragent string |
||
| string_utf16_of("AwsCryptographicMPL/").concat(runtime).concat(&string_utf16_of("/")).concat(&version) | ||
| } | ||
| /// ../mpl/ComAmazonawsKms/Model/ComAmazonawsKmsTypes.dfy(2006,3) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this. Looks like formatter just reshuffle all the function.