-
Notifications
You must be signed in to change notification settings - Fork 142
Add support for syncing BUILD_VERSION=3 images #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scripts/publish.sh
Outdated
# Check if tag in public ECR before attempting to pull | ||
if ! docker manifest inspect public.ecr.aws/aws-observability/aws-for-fluent-bit:${tag} > /dev/null 2>&1; then | ||
echo "Warning: BUILD_VERSION=3 image ${tag} not found in public ECR, skipping sync" | ||
return 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, do we want to eventually return/exit with a non-zero code here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think post launch we may revisit these workarounds and either remove entirely or error
I think the way this script evaluates latest and is plugged in publish.sh, this will never actually sync? Is that right? Looks like the get_latest_dockerhub_version.py would always assign latest to numerically highest 🤔 I wonder how it affects which version we end up syncing with respect to |
Tested offline, lines 1-57 of publish.sh, and it should not be an issue:
I did run an example with an older version for BUILD_VERSION=3
|
c3c4e94
to
6c67c59
Compare
Summary
Add additional sync task steps for BUILD_VERSION=3 with failure handling to allow syncing newer images when available in ecr/dockerhub. Added some sync skips related to missing images in dockerhub/ecr to avoid failures and prevent stable syncing on BUILD_VERSION=3.
Testing
Local pipeline testing of sync task to ensure using the new BUILD_VERSION=3 with nonexistent images in ecr/dockerhub should not fail
Description for the changelog
Enhancement: Add support for syncing BUILD_VERSION=3 images
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.