Fix CognitoUserPoolPreTokenGenerationEventV2 group override details to list #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found this out the hard way - after spending a couple of hours I eventually use Jackson to convert the input CognitoUserPoolPreTokenGenerationEventV2 object to a Map and manually set the List for response group override. Please update the Java objects for CognitoUserPoolPreTokenGenerationEventV2.GroupOverrideDetails as they should be Lists, not Maps. Found on 3.14.0 (maven central). |
Author
|
solved by #519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #516
Description of changes:
CognitoUserPoolPreTokenGenerationEventV2 -> GroupOverrideDetails Response should return list types for groupsToOverride and iamRolesToOverride even when I use V2 pre token generation, not Map<String, String>
This PR is mostly for me to explain the issue and will probably not build because of missing bumping of model version as I don't know how to do that
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.