Fix generation of credentialType(bearer) for non-priority bearer operations #6201
+44
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix generation of credentialType(bearer) for non-priority bearer operations -
.credentialType(TOKEN)
should only ever be set when an operation supports bearer as its first priority auth type - it should not be set when bearer is supported but not prefered (eg@auth[sigv4, bearer]
).Motivation and Context
This fixes an edge case when using legacy (non-sra) signing override on services with mixed sigv4 and bearer support. When a legacy (old, non-sra) signer override is set on the client/request, this code path is triggered and the presence of the Bearer CredentialType causes the AuthorizationStrategyFactory to return bearer instead of sigv4.
Modifications
AuthUtils.isOpBearerAuth
toisOpBearerAuthPreferred
and ensure it returns true IFF (if and only if) the operation should use bearer auth as the first preferred auth scheme.Testing
Add new test cases to cover.
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License