Skip to content

Retry support for Java-based S3 multipart client for multipart GET to bytes #6328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 22, 2025
Merged

Retry support for Java-based S3 multipart client for multipart GET to bytes #6328

merged 22 commits into from
Aug 22, 2025

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Aug 8, 2025 •
edited
Loading

Motivation and Context

Add retry support for Java-based S3 multipart client when multipart downloading with ByteArrayAsyncResponseTransformer

Modifications

  • Add new class ByteArraySplittingTransformer
    • Similar to SplittingTransformer but each IndividualTransformer creates a new ByteArrayAsyncResponseTransformer, in order to support retries
  • Update ByteArrayAsyncResponseTransformer
    • Override split() to use ByteArraySplittingTransformer

Testing

  • Add Wiremock tests and refactor existing tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@davidh44 davidh44 changed the title Retry support for Java-based S3 multipart client when downloading with ByteArrayAsyncResponseTransformer Retry support for Java-based S3 multipart client for multipart GET to bytes Aug 11, 2025
@davidh44 davidh44 marked this pull request as ready for review August 11, 2025 20:55
@davidh44 davidh44 requested a review from a team as a code owner August 11, 2025 20:55
zoewangg
zoewangg requested changes Aug 12, 2025
View reviewed changes
zoewangg
zoewangg reviewed Aug 14, 2025
View reviewed changes
dagnir
dagnir requested changes Aug 14, 2025
View reviewed changes
@davidh44 davidh44 added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Aug 21, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@davidh44 davidh44 added this pull request to the merge queue Aug 22, 2025
Merged via the queue into master with commit c497318 Aug 22, 2025
39 of 41 checks passed
@github-actions GitHub Actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2025
@davidh44 davidh44 deleted the feature/master/multipart-download-byteArrayAsyncResponseTransformer-retry branch August 22, 2025 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dagnir dagnir dagnir approved these changes

@zoewangg zoewangg zoewangg approved these changes

Assignees
No one assigned
Labels
no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidh44 @dagnir @zoewangg