Fix potential NPE in ApiCallAttemptTimeoutTrackingStage

[L-Applin]

fix potential NullPointerException in ApiCallAttemptTimeoutTrackingStage when exception is thrown before the tracker can be set in the context

Motivation and Context

Customer reported NPE because the call to context.apiCallAttemptTimeoutTracker() returns null. There is some code that could throw an exception before the timeoutTracker is set on the context, particularly if the ScheduledExecutorService rejects the scheduled task for some reason.

Modifications

Added null check

Testing

ran unit tests

[zoewangg]

This seems to only fix the symptom, not the root cause, can we create a task to fix the root cause?

[L-Applin]

This seems to only fix the symptom, not the root cause, can we create a task to fix the root cause?

There is always a risk of this happening, I believe the root cause is when the timeout task is rejected by the SCHEDULED_EXECUTOR_SERVICE. The timeSyncTaskIfNeeded will throw an exception before the the timeout tracker is added to the context via context.apiCallAttemptTimeoutTracker(timeoutTracker).

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.