Add VirtualThread HTTP benchmarks #6602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add virtual thread benchmarks for supported HTTP clients. Note that these "benchmarks" act more as verification that virtual threads don't get pinned with various HTTP clients rather than a direct measurement of performance gains or improvements as a result of using virtual threads over platform threads. This commit also refactors existing Apache4 and Apache5Benchmark slightly.
davidh44
reviewed
Dec 2, 2025
test/http-client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/core/ObjectSize.java
Outdated
Show resolved
Hide resolved
...ient-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apache5/Apache5Benchmark.java
Outdated
Show resolved
Hide resolved
...ient-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apache5/Apache5Benchmark.java
Outdated
Show resolved
Hide resolved
...ient-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apache5/Apache5Benchmark.java
Outdated
Show resolved
Hide resolved
...client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/VirtualThreadBenchmark.java
Show resolved
Hide resolved
…dk/benchmark/core/ObjectSize.java Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>
…dk/benchmark/apache5/Apache5Benchmark.java Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>
…dk/benchmark/apache5/Apache5Benchmark.java Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>
…dk/benchmark/apache5/Apache5Benchmark.java Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>
davidh44
approved these changes
Dec 2, 2025
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
* Add VirtualThread HTTP benchmarks Add virtual thread benchmarks for supported HTTP clients. Note that these "benchmarks" act more as verification that virtual threads don't get pinned with various HTTP clients rather than a direct measurement of performance gains or improvements as a result of using virtual threads over platform threads. This commit also refactors existing Apache4 and Apache5Benchmark slightly. * Checkstyle fixes * Sonar fixes * Update test/http-client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/core/ObjectSize.java Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com> * Update test/http-client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apache5/Apache5Benchmark.java Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com> * Update test/http-client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apache5/Apache5Benchmark.java Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com> * Update test/http-client-benchmarks/src/main/java/software/amazon/awssdk/benchmark/apache5/Apache5Benchmark.java Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com> --------- Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add virtual thread benchmarks for supported HTTP clients. Note that these "benchmarks" act more as verification that virtual threads don't get pinned with various HTTP clients rather than a direct measurement of performance gains or improvements as a result of using virtual threads over platform threads.
This commit also refactors existing Apache4 and Apache5Benchmark slightly.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License