Create UploadDirectoryWithResponse api + progress tracking events + update docs and sync exception handling #4187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettBeatty
changed the title
10 tasks
GarrettBeatty
commented
Dec 3, 2025
| /// <returns>The task object representing the asynchronous operation.</returns> | ||
| Task UploadDirectoryAsync(TransferUtilityUploadDirectoryRequest request, CancellationToken cancellationToken = default(CancellationToken)); | ||
|
|
||
| /// <summary> |
Contributor
Author
There was a problem hiding this comment.
i updated the files that the existing uploaddirectory operations were in. i think theres also transfer utility files in the non bcl+standard folder too, but since these are partial classes, they will all be compiled together. so the main thing to update is both the sync + async
GarrettBeatty
force-pushed
the
gcbeatty/uploadfix2
branch
from
89e13c5 to
e96d4a6
Compare
GarrettBeatty
force-pushed
the
uploaddirectorywithresponse
branch
from
d71dcf5 to
6c65537
Compare
Base automatically changed from
gcbeatty/uploadfix2
to
feature/transfermanager
December 3, 2025 16:49
GarrettBeatty
force-pushed
the
uploaddirectorywithresponse
branch
from
7f7679a to
ad837fb
Compare
philasmar
approved these changes
Dec 3, 2025
GarrettBeatty
commented
Dec 3, 2025
| ExceptionDispatchInfo.Capture(e.InnerException).Throw(); | ||
| return null; | ||
| } | ||
| return UploadWithResponseAsync(filePath, bucketName).GetAwaiter().GetResult(); |
Contributor
Author
There was a problem hiding this comment.
updating these as per #4141 (review) since i forgot to update them before
Contributor
Author
There was a problem hiding this comment.
these are all unreleased methods so im updating them
GarrettBeatty
changed the title
GarrettBeatty
commented
Dec 3, 2025
| /// A cancellation token that can be used by other objects or threads to receive notice of cancellation. | ||
| /// </param> | ||
| /// <returns>The task object representing the asynchronous operation.</returns> | ||
| /// <inheritdoc/> |
Contributor
Author
There was a problem hiding this comment.
sneaking in doc updates here too
dscpinheiro
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
To comply with the SEP
Testing
Types of changes
Checklist
License