Remove tests for services without hand-written code and update existing service tests to use async operations #4197
+810
−14,247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate existing service tests to use async operations
dscpinheiro
requested review from
GarrettBeatty,
ashishdhingra and
muhammad-othman
and removed request for
Copilot
Copilot finished reviewing on behalf of
dscpinheiro
December 4, 2025 19:07
GarrettBeatty
approved these changes
Dec 4, 2025
muhammad-othman
approved these changes
Dec 4, 2025
ashishdhingra
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been previously reviewed in #4177 and #4178, but there are a couple of small changes:
UtilityMethods.WaitUntilSuccesswithawait UtilityMethods.WaitUntilAsyncbut the latter is not the same (it only waits once - instead of waiting up to an amount of time). So I updated the utilities class to have the correct overloads (https://github.com/aws/aws-sdk-net/blob/dspin/test-async-refactoring/sdk/test/IntegrationTests/Utils/UtilityMethods.cs#L240)Testing
Dry-run:
DRY_RUN-0ec2d907-71c6-482d-99d5-12b3edf97e6cLicense