ci: enable daily CI run for rust bindings #5328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
The team has decided that we don't need this daily run for s2n-tls. Hence, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Similar to aws/s2n-quic#2624.
Description of changes:
Similar to what we have done in S2N-QUIC, we want the S2N-TLS' rust bindings CI to run daily at 8 PM every day. The run should detect if there are any failures with other jobs. If every jobs succeed, then it would report the value of zero to Cloud Watch metrics, otherwise it would report one. When the Cloud Watch metrics detect one is report, it should fire a Cloud Watch Alarm and cut tickets to our ticketing queue.
The benefits of this daily run is that we can preemptively detect any MSRV bumps of our dependencies. If that should fail the CI, we will receive a notification of that. Engineers shouldn't be surprised by MSRV bump that breaks our CI.
Call-outs:
This code can not be tested without merging. Once this is merged, we should monitor several things daily:
After about 5 days without any problems, we can set up an Cloud Watch Alarm to actually cutting tickets.
Testing:
As mentioned in the
Call-outssection, this code can not be tested without merging. However, we can use this PR to verify that the last job will be called once all of the previous jobs are finished.The CI test can be found here: https://github.com/aws/s2n-tls/actions/runs/15199891804?pr=5328.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.