Skip to content

Conversation

@malav-shastri
Copy link
Member

@malav-shastri malav-shastri commented Oct 30, 2025

…erparameters

Issue #, if available:

Description of changes:
This PR adds support for extracting reward_lambda_arn from Nova recipe files and passing it as a hyperparameter to SageMaker training jobs

Changes made:

  • src/sagemaker/modules/train/sm_recipes/utils.py: Added reward_lambda_arn extraction in _get_args_from_nova_recipe() for ModelTrainer code path
  • src/sagemaker/pytorch/estimator.py: Added reward_lambda_arn extraction in _setup_for_nova_recipe() for PyTorch Estimator code path
  • tests/unit/test_pytorch_nova.py: Added comprehensive test coverage following existing eval_lambda_arn test patterns
  • tests/unit/sagemaker/modules/train/sm_recipes/test_utils.py: Existing test coverage for utils.py path

Testing done:
Unit tests added:

  • test_setup_for_nova_recipe_with_reward_lambda() - verifies successful extraction in PyTorch estimator
  • test_setup_for_nova_recipe_without_reward_lambda() - verifies no extraction when parameter absent
  • Existing test_get_args_from_nova_recipe_with_reward_lambda() - verifies ModelTrainer path

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot and others added 30 commits February 4, 2025 14:18
…ws#5002)

* fix: fix ValueError when updating a data quality monitoring schedule

* Add unit test

* black formatting

---------

Co-authored-by: Erick Benitez-Ramos <141277478+benieric@users.noreply.github.com>
Co-authored-by: parknate@ <parknate@amazon.com>
Co-authored-by: Keshav Chandak <chakesh@amazon.com>
* Add cleanup logic to model builder integ tests for endpoints

* Fix endpoint api call
…lly (aws#5014)

* fix: bug in get latest version was getting the max sorted alphabetically
instead of sem-ver

* handle invalid sev ver and incompatible sagemaker versions

---------

Co-authored-by: Eli Davidson <elleedee@amazon.com>
Co-authored-by: parknate@ <parknate@amazon.com>
Co-authored-by: pintaoz <pintaoz@amazon.com>
* Fix sourcedir.tar.gz filenames in docstrings

* Fix pylint

---------

Co-authored-by: pintaoz <pintaoz@amazon.com>
Co-authored-by: pintaoz <pintaoz@amazon.com>
Co-authored-by: pintaoz <pintaoz@amazon.com>
Co-authored-by: pintaoz <pintaoz@amazon.com>
Co-authored-by: pintaoz <pintaoz@amazon.com>
* Fix all type hint and docstrings for callable

* Fix codestyle

---------

Co-authored-by: pintaoz <pintaoz@amazon.com>
* fix: keep sagemaker_session from being overridden to None, add unit/integ tests

* remove commented code

* fix styling issues

---------

Co-authored-by: Zhaoqi <jzhaoqwa@amazon.com>
… and sagemaker.deserialzers (aws#5037)

* Move RecordSerializer and RecordDeserializer to sagemaker.serializers and sagemaker.deserializers

* fix codestyle

* fix test

---------

Co-authored-by: pintaoz <pintaoz@amazon.com>
* Add framework_version to all TensorFlowModel examples

* update framework_version to x.x.x

---------

Co-authored-by: pintaoz <pintaoz@amazon.com>
…5043)

* fix: pass in inference_ami_version to model_based endpoint type

* documentation: update contributing.md w/ venv instructions and pip install fixes

---------

Co-authored-by: Zhaoqi <jzhaoqwa@amazon.com>
* Add warning about not supporting

* update wording

---------

Co-authored-by: pintaoz <pintaoz@amazon.com>
* added ap-southeast-7 and mx-central-1 for Jumpstart

* added BKK dlc to djl-neuronx

---------

Co-authored-by: Isha Chidrawar <ishachid@amazon.com>
…DK (aws#5050)

Co-authored-by: malavhs <malavhs@amazon.com>
ci and others added 17 commits October 10, 2025 17:32
* add TEI 1.8.2

* add test
* tei

* tests

---------

Co-authored-by: pintaoz-aws <167920275+pintaoz-aws@users.noreply.github.com>
Co-authored-by: Molly He <mollyhe@amazon.com>
* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Fix incompatible_dependecies test

* Fix incompatible_dependecies test

* Fix incompatible_dependecies test

* Fix incompatible_dependecies test

* Fix incompatible_dependecies test

* update tensorflow artifacts

* update tensorflow artifacts

* update tensorflow artifacts

* testfile codestyle fixes

* testfile codestyle fixes

* update SKLearn image URI config

* update SKLearn image URI config

* docstyle fixes

* docstyle fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fix for slow test

* numpy fix for slow test

* numpy fix for slow test

* numpy fix for slow test

* Revert 'Add numpy 2.0 support'

* Revert 'Add numpy 2.0 support'

* Revert 'Add numpy 2.0 support'

---------

Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com>
Co-authored-by: parknate@ <parknate@amazon.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
* image

* tests

---------

Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
* new image

* Update src/sagemaker/image_uri_config/huggingface.json

removed missing CPU image

* add cpu back

---------

Co-authored-by: Molly He <mollyhe@amazon.com>
* add image

* inf on dlc

* neuron tgi dlcs

* fix test

---------

Co-authored-by: Zhaoqi <52220743+zhaoqizqwang@users.noreply.github.com>
* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Fix incompatible_dependecies test

* Fix incompatible_dependecies test

* Fix incompatible_dependecies test

* Fix incompatible_dependecies test

* Fix incompatible_dependecies test

* update tensorflow artifacts

* update tensorflow artifacts

* update tensorflow artifacts

* testfile codestyle fixes

* testfile codestyle fixes

* update SKLearn image URI config

* update SKLearn image URI config

* docstyle fixes

* docstyle fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fixes

* numpy fix for slow test

* numpy fix for slow test

* numpy fix for slow test

* numpy fix for slow test

* Revert 'Add numpy 2.0 support'

* Revert 'Add numpy 2.0 support'

* Revert 'Add numpy 2.0 support'

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

* Add numpy 2.0 support

---------

Co-authored-by: Roja Reddy Sareddy <rsareddy@amazon.com>
Co-authored-by: parknate@ <parknate@amazon.com>
Co-authored-by: Gokul Anantha Narayanan <166456257+nargokul@users.noreply.github.com>
* image

* add py312

* fix

* test fix

* typo

---------

Co-authored-by: Molly He <mollyhe@amazon.com>
@malav-shastri malav-shastri marked this pull request as draft November 6, 2025 01:18
@zhaoqizqwang
Copy link
Contributor

Hi, as part of incoming PySDK V3 release, we request you to change the target branch to master-v2. Master branch will only contain incoming v3 source code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.