[fix] h2 stream manager initial settings not passed correctly & Log the headers #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 79.70% 79.63% -0.07%
==========================================
Files 28 28
Lines 11869 11894 +25
==========================================
+ Hits 9460 9472 +12
- Misses 2409 2422 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TingDaoK
changed the title
DmitriyMusatkin
approved these changes
Jan 30, 2026
| aws_http_headers_get_index(headers, i, &header); | ||
| enum aws_http_header_name name_enum = aws_http_str_to_header_name(header.name); | ||
| switch (name_enum) { | ||
| case AWS_HTTP_HEADER_AUTHORIZATION: |
Contributor
There was a problem hiding this comment.
can we also skip session/security token?
DmitriyMusatkin
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
connectionheader that is also not allowedAn endpoint MUST NOT generate an HTTP/2 message containing connection-specific header fields.so that let's check the headers we send out, and error out if those headers are foundDescription of changes:
authorizationheaders in case of sensitive information.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.