Fix docs, consolidate scripts, and separate dev ports in lexical-graph-hybrid-dev#199
Open
mykola-pereyma wants to merge 6 commits intoawslabs:mainfrom
Open
Fix docs, consolidate scripts, and separate dev ports in lexical-graph-hybrid-dev#199mykola-pereyma wants to merge 6 commits intoawslabs:mainfrom
mykola-pereyma wants to merge 6 commits intoawslabs:mainfrom
Conversation
mykola-pereyma
force-pushed
the
fix/docs-lexical-graph-hybrid-dev
branch
from
960c69d to
fab4ae9
Compare
- Update model names to Claude Sonnet 4, fix role name references - Fix neo4j:// to bolt:// protocol in README - Add DynamoDB step to setup-bedrock-batch-doc.md - Fix broken doc links in notebook cells - Replace hardcoded key_prefix with env var in Cloud-Build notebook - Fix truncated variable in create_prompt_role.ps1
Scripts: - Remove redundant scripts (dev-start.sh, dev-reset.sh, reset.sh, build.sh, .bat files) — superseded by start-containers.sh flags - start-containers.sh/ps1: Add --dev (switches to dev compose), --reset (with extracted/ cleanup), correct port output per mode - Add note when --reset used without --dev Docker: - docker-compose-dev.yml: Remove mysql, separate ports (5434, 8890) - Move Dockerfile.jupyter to jupyter/Dockerfile.dev Docs: - docker_startup_scripts.md: Remove deleted script sections - docker_services.md: Add dev services comparison table
- Auto-attach identity policy to caller's IAM role for non-SSO users - Remove create_custom_prompt.bat (PowerShell version covers Windows)
mykola-pereyma
force-pushed
the
fix/docs-lexical-graph-hybrid-dev
branch
from
fab4ae9 to
a56c198
Compare
oussamahansal
approved these changes
Apr 28, 2026
oussamahansal
approved these changes
Apr 28, 2026
acarbonetto
reviewed
Apr 28, 2026
| AWS_REGION="us-east-1" | ||
| AWS_PROFILE="your-profile" | ||
| AWS_REGION=us-east-1 | ||
| # AWS_PROFILE=default # Optional — uncomment to use a specific profile |
Collaborator
There was a problem hiding this comment.
add comment above line
| networks: | ||
| - graphrag_hybrid_network_dev | ||
|
|
||
| pgvector-hybrid: |
Collaborator
There was a problem hiding this comment.
consider including -dev
| BATCH_SKIPS = {(1, 9): "Requires SOURCE_DIR with PDF files"} | ||
|
|
||
|
|
||
| def load_env(env_path): |
Collaborator
There was a problem hiding this comment.
this doesn't handle quoted values, e.g. GRAPH_STORE="bolt://neo4j:password@neo4j-hybrid:7687"
The standard dotenv format strips quotes
| fi | ||
|
|
||
| # IAM roles | ||
| if [[ "$AWS_RESOURCES_CREATED" == "true" ]]; then |
Collaborator
There was a problem hiding this comment.
The cleanup iterates over bedrock-batch-inference-role and bedrock-prompt-role and detaches all managed policies, not just the ones the script attached. If the role had pre-existing policies, they'd be removed. The || true suppresses errors but the side effect is real.
- Consolidate compose files: add project names, unify notebook mount to /home/jovyan/notebooks, add disable_check_xsrf to dev compose - Remove docker-compose.arm.yml and --mac flag (Docker auto-detects) - Remove all .ps1 PowerShell scripts - Simplify start-containers.sh to --dev and --reset flags only - Add all required dependencies to Dockerfile.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes documentation issues, consolidates redundant Docker scripts into a single entry point, and separates dev/standard ports to allow simultaneous operation.
Changes
Documentation & Notebooks
create_prompt_role.ps1($tem→$tempTrustPolicyFile)key_prefixin notebook 03, 'Netune' typo in notebook 04neo4j://→bolt://protocol in READMEScript Consolidation
dev-start.sh,dev-reset.sh,reset.sh,build.sh,start-containers.bat,create_custom_prompt.batstart-containers.sh/.ps1with--dev,--reset,--macflags--devnow switches todocker-compose-dev.yml(previously exported unused env var)--resetcleansextracted/directory for fresh startDocker
Dockerfile.jupyter→jupyter/Dockerfile.devTesting
All changes tested end-to-end in dev mode on macOS:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.