-
Notifications
You must be signed in to change notification settings - Fork 85
Feature/Parameterize Bedrock model ID in CloudFormation templates #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -73,6 +73,11 @@ | |||||
| "Type": "String", | ||||||
| "Description": "URL of a zip file containing example notebooks to be installed on SageMaker instance (optional)", | ||||||
| "Default": "https://github.com/awslabs/graphrag-toolkit/releases/latest/download/lexical-graph-examples-latest.zip" | ||||||
| }, | ||||||
| "BedrockModelId": { | ||||||
| "Description": "Bedrock model ID used for extraction, response, and evaluation LLMs", | ||||||
| "Type": "String", | ||||||
| "Default": "anthropic.claude-sonnet-4-6" | ||||||
| } | ||||||
| }, | ||||||
| "Metadata": { | ||||||
|
|
@@ -83,7 +88,8 @@ | |||||
| "default": "Setup" | ||||||
| }, | ||||||
| "Parameters": [ | ||||||
| "ApplicationId" | ||||||
| "ApplicationId", | ||||||
| "BedrockModelId" | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
@@ -792,10 +798,10 @@ | |||||
| ], | ||||||
| "Resource": [ | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*::foundation-model/anthropic.*" | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*::foundation-model/${BedrockModelId}" | ||||||
| }, | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*:${AWS::AccountId}:inference-profile/*.anthropic.*" | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*:${AWS::AccountId}:inference-profile/*.${BedrockModelId}" | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need the wildcard for profiles, since the profile passed in would contain the prefix.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We might need to go with something like |
||||||
| }, | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:${AWS::Region}::foundation-model/cohere.embed-english-v3" | ||||||
|
|
@@ -943,15 +949,15 @@ | |||||
| }, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EXTRACTION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EMBEDDINGS_MODEL=cohere.embed-english-v3\" >> ~/.bashrc\n", | ||||||
| "echo \"export EMBEDDINGS_DIMENSIONS=1024\" >> ~/.bashrc\n", | ||||||
| "echo \"export RESPONSE_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EVALUATION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export GRAPH_NOTEBOOK_AUTH_MODE=IAM\" >> ~/.bashrc\n", | ||||||
| "echo \"export GRAPH_NOTEBOOK_SSL=True\" >> ~/.bashrc\n", | ||||||
|
|
@@ -1111,15 +1117,15 @@ | |||||
| }, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EXTRACTION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EMBEDDINGS_MODEL=cohere.embed-english-v3\" >> .env\n", | ||||||
| " echo \"export EMBEDDINGS_DIMENSIONS=1024\" >> .env\n", | ||||||
| " echo \"export RESPONSE_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EVALUATION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " if [ -f \"./run_test_suite.sh\" ]\n", | ||||||
| " then\n", | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -47,6 +47,11 @@ | |||||
| "Type": "String", | ||||||
| "Description": "URL of a zip file containing example notebooks to be installed on SageMaker instance (optional)", | ||||||
| "Default": "https://github.com/awslabs/graphrag-toolkit/releases/latest/download/lexical-graph-examples-latest.zip" | ||||||
| }, | ||||||
| "BedrockModelId": { | ||||||
| "Description": "Bedrock model ID used for extraction, response, and evaluation LLMs", | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| "Type": "String", | ||||||
| "Default": "anthropic.claude-sonnet-4-6" | ||||||
| } | ||||||
| }, | ||||||
| "Metadata": { | ||||||
|
|
@@ -57,7 +62,8 @@ | |||||
| "default": "Setup" | ||||||
| }, | ||||||
| "Parameters": [ | ||||||
| "ApplicationId" | ||||||
| "ApplicationId", | ||||||
| "BedrockModelId" | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
@@ -409,10 +415,10 @@ | |||||
| ], | ||||||
| "Resource": [ | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*::foundation-model/anthropic.*" | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*::foundation-model/${BedrockModelId}" | ||||||
| }, | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*:${AWS::AccountId}:inference-profile/*.anthropic.*" | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*:${AWS::AccountId}:inference-profile/*.${BedrockModelId}" | ||||||
| }, | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:${AWS::Region}::foundation-model/cohere.embed-english-v3" | ||||||
|
|
@@ -1019,15 +1025,15 @@ | |||||
| }, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EXTRACTION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EMBEDDINGS_MODEL=cohere.embed-english-v3\" >> ~/.bashrc\n", | ||||||
| "echo \"export EMBEDDINGS_DIMENSIONS=1024\" >> ~/.bashrc\n", | ||||||
| "echo \"export RESPONSE_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EVALUATION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export GRAPH_NOTEBOOK_AUTH_MODE=IAM\" >> ~/.bashrc\n", | ||||||
| "echo \"export GRAPH_NOTEBOOK_SSL=True\" >> ~/.bashrc\n", | ||||||
|
|
@@ -1167,15 +1173,15 @@ | |||||
| }, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EXTRACTION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EMBEDDINGS_MODEL=cohere.embed-english-v3\" >> .env\n", | ||||||
| " echo \"export EMBEDDINGS_DIMENSIONS=1024\" >> .env\n", | ||||||
| " echo \"export RESPONSE_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EVALUATION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " if [ -f \"./run_test_suite.sh\" ]\n", | ||||||
| " then\n", | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -47,6 +47,11 @@ | |||||
| "Type": "String", | ||||||
| "Description": "URL of a zip file containing example notebooks to be installed on SageMaker instance (optional)", | ||||||
| "Default": "https://github.com/awslabs/graphrag-toolkit/releases/latest/download/lexical-graph-examples-latest.zip" | ||||||
| }, | ||||||
| "BedrockModelId": { | ||||||
| "Description": "Bedrock model ID used for extraction, response, and evaluation LLMs", | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| "Type": "String", | ||||||
| "Default": "anthropic.claude-sonnet-4-6" | ||||||
| } | ||||||
| }, | ||||||
| "Metadata": { | ||||||
|
|
@@ -57,7 +62,8 @@ | |||||
| "default": "Setup" | ||||||
| }, | ||||||
| "Parameters": [ | ||||||
| "ApplicationId" | ||||||
| "ApplicationId", | ||||||
| "BedrockModelId" | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
@@ -305,10 +311,10 @@ | |||||
| ], | ||||||
| "Resource": [ | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*::foundation-model/anthropic.*" | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*::foundation-model/${BedrockModelId}" | ||||||
| }, | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*:${AWS::AccountId}:inference-profile/*.anthropic.*" | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*:${AWS::AccountId}:inference-profile/*.${BedrockModelId}" | ||||||
| }, | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:${AWS::Region}::foundation-model/cohere.embed-english-v3" | ||||||
|
|
@@ -448,15 +454,15 @@ | |||||
| }, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EXTRACTION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EMBEDDINGS_MODEL=cohere.embed-english-v3\" >> ~/.bashrc\n", | ||||||
| "echo \"export EMBEDDINGS_DIMENSIONS=1024\" >> ~/.bashrc\n", | ||||||
| "echo \"export RESPONSE_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EVALUATION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export GRAPH_NOTEBOOK_AUTH_MODE=IAM\" >> ~/.bashrc\n", | ||||||
| "echo \"export GRAPH_NOTEBOOK_SSL=True\" >> ~/.bashrc\n", | ||||||
|
|
@@ -604,15 +610,15 @@ | |||||
| }, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EXTRACTION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EMBEDDINGS_MODEL=cohere.embed-english-v3\" >> .env\n", | ||||||
| " echo \"export EMBEDDINGS_DIMENSIONS=1024\" >> .env\n", | ||||||
| " echo \"export RESPONSE_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EVALUATION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " if [ -f \"./run_test_suite.sh\" ]\n", | ||||||
| " then\n", | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -134,6 +134,11 @@ | |||||
| "Type": "String", | ||||||
| "Description": "URL of a zip file containing example notebooks to be installed on SageMaker instance (optional)", | ||||||
| "Default": "https://github.com/awslabs/graphrag-toolkit/releases/latest/download/lexical-graph-examples-latest.zip" | ||||||
| }, | ||||||
| "BedrockModelId": { | ||||||
| "Description": "Bedrock model ID used for extraction, response, and evaluation LLMs", | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| "Type": "String", | ||||||
| "Default": "anthropic.claude-sonnet-4-6" | ||||||
| } | ||||||
| }, | ||||||
| "Metadata": { | ||||||
|
|
@@ -144,7 +149,8 @@ | |||||
| "default": "Setup" | ||||||
| }, | ||||||
| "Parameters": [ | ||||||
| "ApplicationId" | ||||||
| "ApplicationId", | ||||||
| "BedrockModelId" | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
|
|
@@ -732,10 +738,10 @@ | |||||
| ], | ||||||
| "Resource": [ | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*::foundation-model/anthropic.*" | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*::foundation-model/${BedrockModelId}" | ||||||
| }, | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*:${AWS::AccountId}:inference-profile/*.anthropic.*" | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:*:${AWS::AccountId}:inference-profile/*.${BedrockModelId}" | ||||||
| }, | ||||||
| { | ||||||
| "Fn::Sub": "arn:${AWS::Partition}:bedrock:${AWS::Region}::foundation-model/cohere.embed-english-v3" | ||||||
|
|
@@ -1382,15 +1388,15 @@ | |||||
| "Ref": "AWS::StackId" | ||||||
| }, | ||||||
| "echo \"export EXTRACTION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EMBEDDINGS_MODEL=cohere.embed-english-v3\" >> ~/.bashrc\n", | ||||||
| "echo \"export EMBEDDINGS_DIMENSIONS=1024\" >> ~/.bashrc\n", | ||||||
| "echo \"export RESPONSE_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export EVALUATION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> ~/.bashrc\n", | ||||||
| "echo \"export GRAPH_NOTEBOOK_AUTH_MODE=IAM\" >> ~/.bashrc\n", | ||||||
| "echo \"export GRAPH_NOTEBOOK_SSL=True\" >> ~/.bashrc\n", | ||||||
|
|
@@ -1564,15 +1570,15 @@ | |||||
| }, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EXTRACTION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EMBEDDINGS_MODEL=cohere.embed-english-v3\" >> .env\n", | ||||||
| " echo \"export EMBEDDINGS_DIMENSIONS=1024\" >> .env\n", | ||||||
| " echo \"export RESPONSE_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export EVALUATION_MODEL=", | ||||||
| "anthropic.claude-sonnet-4-6", | ||||||
| {"Ref": "BedrockModelId"}, | ||||||
| "\" >> .env\n", | ||||||
| " echo \"export LOCAL_EXTRACT_S3=", | ||||||
| { | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.