refactor: optimize dashboard widget selection#3132
Open
tracy-french wants to merge 10 commits intorcfrom
Open
Conversation
tracy-french
force-pushed
the
refactor-widget-selection
branch
2 times, most recently
from
d70b790 to
32219bf
Compare
tracy-french
changed the title
tracy-french
force-pushed
the
refactor-widget-selection
branch
from
32219bf to
8f552ec
Compare
tracy-french
force-pushed
the
refactor-widget-selection
branch
from
8f552ec to
48b4607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change refactors widget selection, and the related code which depends on it, such as gestures, copy/paste, etc., to only rely on widget IDs, instead of entire widget instance objects. This provides a small, yet noticeable performance improvement due to the elimination of referential purity concerns causing cascading re-renders on the code which depends on selected widgets. Performance gains may be fully realized by ensuring comprehensive memoization of dependent components and pushing the selection state down into leaf node components where actually utilized.
Legal
This project is available under the Apache 2.0 License.