Open
Conversation
Contributor
|
Hi, sounds like this is something I'd take, but it has conflicts, and we're going to be pushing some other stuff in the very near future. If you could re-spin in a couple of days? |
xentek
added a commit
to groundbreaker/statelint
that referenced
this pull request
Oct 31, 2019
`Map` states allow two optional fields, `ItemsPath` and `MaxConcurrency`, which were being incorrectly raised as errors when parsing state machines that made use of these fields. - updates the _j2119_ specification to allow for these fields (fixes awslabs#29) - cleans up warnings when building the gemspec by specifying the version of the `j2119` gem in a more constrained manner. - updates `Gemfile` so that the version of `j2119` agrred with the version in the `gemspec` - removed unnecessary `$LOAD_PATH` manipulation from all ruby files in the project (refs awslabs#20)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I read your spec file today and saw that
linterwas defined twice in quick succession, and it didn't need to be from what I could tell. I've removed these.At the top of your tests you're also modifying
$:, the Ruby loadpath. This will addlibtwice to the loadpath (once for each test) and it is unnecessary because RSpec automatically adds thelibpath to your loadpath during the test run.Similarly, the loadpath modification in
lib/statelint.rbis not required either. Bundler (and RubyGems, iirc) will add thelibdirectory to the loadpath for you. You're doubling up here again.I also noticed that you were missing
rspecfrom your Gemfile. This should be added to theGemfile, as its a gem that is required to work on this project. I added it for you.I've also cleaned up a few extra spaces / lines that weren't required.