Relax requirement for URI on Resource Field.#33
Open
zbintliff wants to merge 1 commit intoawslabs:masterfrom
Open
Relax requirement for URI on Resource Field.#33zbintliff wants to merge 1 commit intoawslabs:masterfrom
zbintliff wants to merge 1 commit intoawslabs:masterfrom
Conversation
The URI check is just `value =~ /^[a-z]+:/` which doesn't even make sure
the value is a valid ARN just that it starts with a letter and has a
`:`.
We use terraform to manage our StepFunctions. Because we operate in a
few different regions we template out the JSON (still valid json!) an
then use terraform templating to create the template and manage teht
SFN. There is no time after terraform interpolates variables for us to
run a file through the linter (its all in memory).
We are just running into this because instead of interpolating region in
the ARN we are now using a data resource to allow terraform to drop the
whole ARN in.
That is we are going from:
```
"Resource": "arn:aws:lambda:${region}:${account}:function:foobar:${alias}"
```
To:
```
"Resource": "${lambda_arn}"
```
The first passes the very lax regex the second doesn't
zbintliff
force-pushed
the
feature/relax-resource-constraint
branch
from
aa6bbad to
b898f80
Compare
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URI check is just
value =~ /^[a-z]+:/which doesn't even make surethe value is a valid ARN just that it starts with a letter and has a
:.We use terraform to manage our StepFunctions. Because we operate in a
few different regions we template out the JSON (still valid json!) an
then use terraform templating to create the template and manage teht
SFN. There is no time after terraform interpolates variables for us to
run a file through the linter (its all in memory).
We are just running into this because instead of interpolating region in
the ARN we are now using a data resource to allow terraform to drop the
whole ARN in.
That is we are going from:
To:
The first passes the very lax regex the second doesn't
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.