Open
Conversation
MatejNedic
requested review from
maciejwalkowiak and
tomazfernandes
as code owners
github-actions
bot
added
component: sns
...-cloud-aws-sns/src/main/java/io/awspring/cloud/sns/core/async/PublishRequestMessagePair.java
Outdated
Show resolved
Hide resolved
spring-cloud-aws-sns/src/main/java/io/awspring/cloud/sns/core/async/SnsResult.java
Outdated
Show resolved
Hide resolved
| * @author Gyozo Papp | ||
| * @author Matej Nedic | ||
| */ | ||
| public class SnsHeaderConverterUtil { |
Contributor
There was a problem hiding this comment.
Can it be package private? (in general i don't like util classes but i don't like them even more when they are public ;))
Member
Author
There was a problem hiding this comment.
Since DefaultSnsPublishMessageConverter is in package io.awspring.cloud.sns.core.async and TopicChannel is in io.awspring.cloud.sns.core
i would have to move them to same package
# Conflicts: # spring-cloud-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/sns/SnsAutoConfiguration.java # spring-cloud-aws-autoconfigure/src/test/java/io/awspring/cloud/autoconfigure/sns/SnsAutoConfigurationTest.java # spring-cloud-aws-sns/src/main/java/io/awspring/cloud/sns/core/SnsHeaderConverterUtil.java
Member
Author
|
Updated PR comments and resolved conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Introduction of SnsAsyncTemplate for async notification sending.
💡 Motivation and Context
Closes #1568
💚 How did you test it?
📝 Checklist
🔮 Next steps