Refactor SNSTemplate tests to use LocalstackContainerTest#1580
Open
haroya01 wants to merge 1 commit intoawspring:mainfrom
Open
Refactor SNSTemplate tests to use LocalstackContainerTest#1580haroya01 wants to merge 1 commit intoawspring:mainfrom
haroya01 wants to merge 1 commit intoawspring:mainfrom
Conversation
Extract shared LocalStack container setup into LocalstackContainerTest interface, following the same pattern used in the S3 and DynamoDB modules. Fixes awspringgh-1579
haroya01
requested review from
MatejNedic,
maciejwalkowiak and
tomazfernandes
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract shared LocalStack container setup into LocalstackContainerTest interface, following the same pattern used in the S3 and DynamoDB modules.
Fixes gh-1579
📢 Type of change
📜 Description
Extract duplicated LocalStack container setup code from three SNS integration tests into a shared LocalstackContainerTest interface.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps