Skip to content

Conversation

@bloerwald
Copy link
Collaborator

@bloerwald bloerwald commented Aug 13, 2023

As requested in #41, all localisation usage is now using "non readable" keys with sane prefixes. Since this requires reimporting all localisation data, this also removes unused strings and cleans up some obvious bogus data.

This PR can be reviewed entirely in the data added to the repository. If this data looks sane, it is required to

  • delete all localisation data from curseforge
  • reimport the data from Localization/rename/*.lua
  • delete Localization/rename/*
  • remove the ns.L["new"] = ns.L['old'] lines from Core/Addon.lua
  • merge

You can test it by replacing Localization/enUS.lua with Localisation/rename/enUS.lua, adding

local L = LibStub('AceLocale-3.0'):NewLocale('PetBattleScripts', 'enUS')
if not L then return end

on top.

@bloerwald bloerwald force-pushed the issue_41-clean_up_localization branch from 1eea24a to a25e97d Compare October 26, 2023 13:17
@bloerwald
Copy link
Collaborator Author

bloerwald commented Oct 26, 2023

force push: drop #34, add changelog entry

@bloerwald bloerwald force-pushed the issue_41-clean_up_localization branch from a25e97d to accd57e Compare October 26, 2023 20:44
@bloerwald
Copy link
Collaborator Author

  • delete all localisation data from curseforge
  • reimport the data from Localization/rename/*.lua
  • delete Localization/rename/* d3444f3
  • remove the ns.L["new"] = ns.L['old'] lines from Core/Addon.lua

@bloerwald bloerwald merged commit a1e3c70 into master Oct 26, 2023
@bloerwald bloerwald deleted the issue_41-clean_up_localization branch October 29, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants