Skip to content

Add landing page#12

Closed
axeldelafosse wants to merge 1 commit intomainfrom
loop-loop-15
Closed

Add landing page#12
axeldelafosse wants to merge 1 commit intomainfrom
loop-loop-15

Conversation

@axeldelafosse
Copy link
Copy Markdown
Owner

Summary

  • Adds a single-file landing page at site/index.html — dark, minimal, developer-focused
  • No JS frameworks, no build step, no external dependencies — pure HTML + inline CSS
  • Includes install command with copy button, usage examples, and feature list
  • Fixes missing cwd property in tmux test

Design

  • Dark background (#0a0a0a), monospace font stack, single accent color
  • Narrow max-width (640px), no images/icons/illustrations
  • Only JS is a 5-line inline clipboard copy handler

Test plan

  • Open site/index.html in a browser and verify layout
  • Test copy button copies the install command
  • Verify page looks reasonable on mobile viewport
  • Run bun run check to ensure no lint/type regressions

Single-file dark, minimal landing page at site/index.html.
No frameworks, no build step — pure HTML + inline CSS.
Also fixes missing cwd in tmux test.
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @axeldelafosse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, self-contained landing page for the "loop" project, designed to provide essential information and installation instructions without external dependencies. Concurrently, it addresses a minor but important fix in a tmux-related test to ensure proper execution context.

Highlights

  • New Landing Page: Introduced a new, minimalist, developer-focused landing page at "site/index.html". It's built with pure HTML and inline CSS, featuring an install command with a copy button, usage examples, and a feature list.
  • Test Fix: Resolved a missing "cwd" property in the "runInTmux" test within "tests/loop/tmux.test.ts" to ensure correct execution context.
Changelog
  • site/index.html
    • Added a new landing page for the project.
  • tests/loop/tmux.test.ts
    • Added a "cwd" property to the "runInTmux" call in a test.
Activity
  • No activity has occurred on this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new landing page for the loop project, featuring a dark, minimal, and developer-focused design with pure HTML and inline CSS. It also includes a fix for a missing cwd property in a tmux test. The landing page is well-structured and provides essential information about the project, including installation instructions, usage examples, and features. The tmux test fix addresses a potential issue in the test suite. Overall, the changes are positive and enhance the project's presentation and test reliability.

Comment thread site/index.html
<section class="install">
<h2>Install</h2>
<pre
><code>curl -fsSL https://raw.githubusercontent.com/axeldelafosse/loop/main/install.sh | bash</code></pre>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pre tag has an unnecessary newline before the <code> tag. This can be cleaned up for better readability and consistency.

Suggested change
><code>curl -fsSL https://raw.githubusercontent.com/axeldelafosse/loop/main/install.sh | bash</code></pre>
><code

Comment thread site/index.html
<section>
<h2>Usage</h2>
<pre
><code>loop --prompt "Implement auth flow" --proof "All tests pass" --worktree
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pre tag has an unnecessary newline before the <code> tag. This can be cleaned up for better readability and consistency.

Suggested change
><code>loop --prompt "Implement auth flow" --proof "All tests pass" --worktree
><code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant