feat: unify agent turn timeout and fix codex render boundary#18
feat: unify agent turn timeout and fix codex render boundary#18axeldelafosse merged 1 commit intomainfrom
Conversation
- Extract AGENT_TURN_TIMEOUT_MS (≈11.7h) into constants.ts as single source of truth - Replace per-file WAIT_TIMEOUT_MS / DEFAULT_WAIT_TIMEOUT_MS with shared constant - Fix codex renderer skipping message boundary when completed event matches active delta stream
Summary of ChangesHello @axeldelafosse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors agent timeout mechanisms by consolidating disparate timeout constants into a single, shared source and substantially extending the timeout duration to accommodate prolonged agent interactions. Additionally, it addresses a rendering anomaly in the Codex agent to ensure cleaner output by preventing unnecessary message boundaries when streaming content. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully unifies the agent turn timeout into a single constant, AGENT_TURN_TIMEOUT_MS, and significantly increases its value to support long-running sessions. The change is correctly applied across both the Claude and Codex servers. Additionally, it introduces a fix in the Codex renderer to prevent extra newlines, improving output formatting. The changes are logical and well-implemented. I have one suggestion regarding the new timeout constant to improve code maintainability.
Summary
AGENT_TURN_TIMEOUT_MSconstant inconstants.ts, replacing the duplicatedWAIT_TIMEOUT_MS(codex) andDEFAULT_WAIT_TIMEOUT_MS(claude) definitions. Both servers now import from one source of truth.completedevent matches an item already streamed via deltas, preventing spurious line breaks mid-stream.Test plan
bun run check— passes cleanly