Skip to content

Add classLoader to project-build-plugin validation context#1048

Open
alexsuter wants to merge 1 commit intomasterfrom
classloader
Open

Add classLoader to project-build-plugin validation context#1048
alexsuter wants to merge 1 commit intomasterfrom
classloader

Conversation

@alexsuter
Copy link
Copy Markdown
Member

No description provided.

@alexsuter alexsuter marked this pull request as ready for review April 23, 2026 06:33
@alexsuter alexsuter requested a review from ivy-edp April 23, 2026 06:33
Copy link
Copy Markdown
Member

@ivy-edp ivy-edp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥇

@alexsuter
Copy link
Copy Markdown
Member Author

@weissreto just that you get the full overview. the classloader which is needed by the validators needs to be provided by the framework/context. in the project-build-plugin only the plugin itself knows the classpath of the project. in the lsp-validation-endpoints there is still JavaRuntime.of(project).getClassLoader() in use. We already should differ in the core between a compile classpath and a runtime classpath. Later on, we can switch from a classloader to a yandex based index.

@ivy-rew
Copy link
Copy Markdown
Member

ivy-rew commented Apr 23, 2026

@weissreto just that you get the full overview. the classloader which is needed by the validators needs to be provided by the framework/context. in the project-build-plugin only the plugin itself knows the classpath of the project. in the lsp-validation-endpoints there is still JavaRuntime.of(project).getClassLoader() in use. We already should differ in the core between a compile classpath and a runtime classpath. Later on, we can switch from a classloader to a yandex based index.

Thanks for sharing the context among the team 🤝 🥇

@alexsuter
Copy link
Copy Markdown
Member Author

I think this is the right approach. But not working because we only have ivy-runtime.jar on the compile classpath and all dependency from thirdparty-libs are currently missing.
we need to wait with them until we publish the official jars with it's dependencies to maven repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants