XIVY-18799 create process and casemap with spaces in namespace#1137
Open
XIVY-18799 create process and casemap with spaces in namespace#1137
Conversation
There was a problem hiding this comment.
Pull request overview
Updates namespace validation for creating processes and case maps to allow spaces within namespace segments (while still using / as the separator).
Changes:
- Replace the namespace validator with a new regex that permits spaces within segments.
- Update process/case-map creation flows to use the new validator.
- Expand and adjust unit tests for the updated namespace validation behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| extension/src/project-explorer/utils/util.ts | Introduces validateNamespaceWithSpace with updated namespace regex + message. |
| extension/src/project-explorer/utils/util.test.ts | Updates tests to exercise the new namespace rules (and adds new cases). |
| extension/src/project-explorer/new-process.ts | Switches the namespace input step to the new validator. |
| extension/src/project-explorer/new-case-map.ts | Switches the namespace input step to the new validator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support spaces within word groups in the namespace input. Allowed for