Open
Conversation
Implement inital (client-side) support for diagram diffing with the process editor - Update configuration defaults for p.json files so that files associated with a git scheme are opened with the text editor by default -> When opening a diff view for a p.json file from the git view the default text compare editor is openend by default - Add an entry to the title bar of the text diff editor that allows reopening in the diagram compare view (use artificial uris with pdiff extension so that we can distinguish between files that are openend normally and in compare mode) - Update process editor provider to handle .pdiff uris - Extract diff info (id, side, uri) from pdiff uris forward it to the webview - Update the webview so that it attaches optionally present diff information to the args of the `RequestModelAction` Missing: - Server-side implementation. Currently the optional diff args are not evaluated and the server just openes the file normally
Member
|
Hi @tortmayr, should this pr be reviewed already? I ask because it is in draft state. |
Author
|
@ivy-lmu Sorry for that. Yes the PR is ready for review. |
Member
|
hello @tortmayr many thanks, the text-based comparison is already a great improvement. I'm just merging this default configuration change for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement inital (client-side) support for diagram diffing with the process editor
RequestModelActionMissing: