feat: add skeleton loading states for cached edit views#3387
Open
HerbertJulio wants to merge 1 commit intodevfrom
Open
feat: add skeleton loading states for cached edit views#3387HerbertJulio wants to merge 1 commit intodevfrom
HerbertJulio wants to merge 1 commit intodevfrom
Conversation
Add EditViewSkeleton components for EdgeFirewall, EdgeServices, and WafRules edit views that use cached listing data without proper skeleton loading states during data fetch. ENG-36889
HerbertJulio
requested review from
gdsantana,
isaquebock,
pauloSF0,
rafaelgarbinatto and
robsongajunior
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EditViewSkeletoncomponents for EdgeFirewall, EdgeServices, and WafRules edit viewsChanges
src/views/EdgeFirewall/components/EditViewSkeleton.vue— new skeleton componentsrc/views/EdgeServices/components/EditViewSkeleton.vue— new skeleton componentsrc/views/WafRules/components/EditViewSkeleton.vue— new skeleton componentsrc/views/EdgeFirewall/TabsView.vue— integrate skeleton during loadingsrc/views/EdgeServices/TabsView.vue— integrate skeleton during loadingsrc/views/WafRules/TabsView.vue— integrate skeleton during loadingTest plan
ENG-36889