fix: resolve navbar flash on navigation and workload protocol error#3388
Open
HerbertJulio wants to merge 1 commit intodevfrom
Open
fix: resolve navbar flash on navigation and workload protocol error#3388HerbertJulio wants to merge 1 commit intodevfrom
HerbertJulio wants to merge 1 commit intodevfrom
Conversation
…36926) - logoutGuard: only call startLoading for logout routes instead of every navigation, eliminating the navbar flash - layout: use isBootstrapping computed (hasSession + route meta) to control navbar skeleton and footer visibility, replacing loading store - layout: wrap router-view to prevent footer from sticking to header - workload form: add optional chaining to protocols.http access
HerbertJulio
requested review from
gdsantana,
isaquebock,
pauloSF0,
rafaelgarbinatto and
robsongajunior
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cannot read properties of undefined (reading 'http')runtime error in Workload protocol settingsRoot Cause
logoutGuardcalledstartLoading()on every navigation, causing the entire navbar to collapse and rebuildprotocolSettingsBlock.vueaccessed nested properties without optional chaining on a potentially undefined objectChanges
src/router/hooks/guards/logoutGuard.js— MovestartLoading()inside the logout condition onlysrc/layout/index.vue— AddisBootstrappingcomputed (based on persistedhasSession) for skeleton state; wrap router-view in flex container to fix footer positioningsrc/layout/app-navbar.vue— ReplaceisLoadingprop withisBootstrappingfor skeleton displaysrc/views/Workload/FormFields/blocks/protocolSettingsBlock.vue— Add optional chaining to allprotocols.httpaccessesTest plan
ENG-36926