Skip to content

[TASK] make CI happy again #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmack merged 1 commit into from
Jan 12, 2026
Merged

[TASK] make CI happy again #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions Build/phpstan-baseline12.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,37 @@ parameters:
message: "#^Instanceof between array and TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface will always evaluate to false\\.$#"
count: 1
path: ../Classes/Backend/Preview/StandardContentPreviewRenderer.php
-
message: "#^Call to method get\\(\\) on an unknown class TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface\\.$#"
count: 1
path: ../Classes/Service/DatabaseRowService.php

-
message: "#^Call to method getMainType\\(\\) on an unknown class TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface\\.$#"
count: 2
path: ../Classes/Service/DatabaseRowService.php

-
message: "#^Call to method getPid\\(\\) on an unknown class TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface\\.$#"
count: 1
path: ../Classes/Service/DatabaseRowService.php

-
message: "#^Call to method getRawRecord\\(\\) on an unknown class TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface\\.$#"
count: 1
path: ../Classes/Service/DatabaseRowService.php

-
message: "#^Call to method getUid\\(\\) on an unknown class TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface\\.$#"
count: 2
path: ../Classes/Service/DatabaseRowService.php

-
message: "#^Parameter \\#2 \\$idOrRow of method TYPO3\\\\CMS\\\\Core\\\\Authentication\\\\BackendUserAuthentication\\:\\:recordEditAccessInternals\\(\\) expects array\\|int, TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface given\\.$#"
count: 1
path: ../Classes/Service/DatabaseRowService.php

-
message: "#^Parameter \\$record of method B13\\\\Backendpreviews\\\\Service\\\\DatabaseRowService\\:\\:getAdditionalDataForView\\(\\) has invalid type TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface\\.$#"
count: 1
path: ../Classes/Service/DatabaseRowService.php
4 changes: 4 additions & 0 deletions Build/phpstan-baseline13.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,7 @@ parameters:
message: "#^Call to an undefined method TYPO3\\\\CMS\\\\Core\\\\Database\\\\Query\\\\QueryBuilder\\:\\:add\\(\\)\\.$#"
count: 1
path: ../Classes/ViewHelpers/GetDatabaseRecordViewHelper.php
-
message: "#^Parameter \\#2 \\$row of method TYPO3\\\\CMS\\\\Core\\\\Authentication\\\\BackendUserAuthentication\\:\\:recordEditAccessInternals\\(\\) expects array, TYPO3\\\\CMS\\\\Core\\\\Domain\\\\RecordInterface given\\.$#"
count: 1
path: ../Classes/Service/DatabaseRowService.php
1 change: 1 addition & 0 deletions Classes/Backend/Preview/StandardContentPreviewRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ public function renderPageModulePreviewContent(GridColumnItem $item): string
$record = $item->getRecord();
$context = $item->getContext();
$contentPreview = GeneralUtility::makeInstance(ContentPreview::class);
// note: this is only v14 s. https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Breaking-92434-UseRecordAPIInPageModulePreviewRendering.html
if ($record instanceof RecordInterface) {
$content = $contentPreview->render($record, $context);
} else {
Expand Down
11 changes: 8 additions & 3 deletions Classes/Service/DatabaseRowService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
use TYPO3\CMS\Backend\Utility\BackendUtility;
use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
use TYPO3\CMS\Core\Domain\RecordInterface;
use TYPO3\CMS\Core\Information\Typo3Version;
use TYPO3\CMS\Core\Localization\LanguageService;
use TYPO3\CMS\Core\Resource\FileReference;
use TYPO3\CMS\Core\Resource\FileRepository;
use TYPO3\CMS\Core\Service\FlexFormService;
use TYPO3\CMS\Core\SingletonInterface;
use TYPO3\CMS\Core\Utility\GeneralUtility;

class DatabaseRowService implements SingletonInterface
class DatabaseRowService
{
protected FileRepository $fileRepository;

Expand All @@ -35,7 +35,12 @@ public function __construct(FileRepository $fileRepository)
public function getAdditionalDataForView(RecordInterface $record): array
{
$data = [];
if ($this->getBackendUser()->recordEditAccessInternals($record->getMainType(), $record)) {
if ((new Typo3Version())->getMajorVersion() < 14) {
$editAccess = $this->getBackendUser()->recordEditAccessInternals($record->getMainType(), $record->getRawRecord()->toArray());
} else {
$editAccess = $this->getBackendUser()->recordEditAccessInternals($record->getMainType(), $record);
}
if ($editAccess) {
$urlParameters = [
'edit' => [
'tt_content' => [
Expand Down