feat(routes): Help Requests API Endpoints with validation#35
Merged
prdai merged 7 commits intob3-competition:mainfrom Jul 5, 2025
Merged
Conversation
prdai
requested changes
Jun 30, 2025
Contributor
There was a problem hiding this comment.
try to match this what is in @Thilina2468 's PR #34
|
|
||
| router.get('/', async (_req, res) => { | ||
| try { | ||
| const snapshot = await requestsCol.get(); |
Contributor
There was a problem hiding this comment.
the storage needs to be created and then their reference ids or something should be in the atttachements in the firestore btw like a list of strings which has ids which we can refer to in the storage...
| } | ||
| }); | ||
|
|
||
| router.put('/:requestId', validate(updateRequestSchema), async (req, res) => { |
Contributor
There was a problem hiding this comment.
here also you have to integrate the firebase storage as required as well...
- Removed the old requests.js route file. - Introduced helpRequest.js route file with updated request handling logic. - Updated app.js to use the new helpRequest router. - Enhanced attachment handling in the new route.
…com/Methika1234/disasterops-core-api into feat-27-help-requests-api-endpoints
prdai
approved these changes
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #27