Implement complete task assignment API endpoints with Bruno tests#40
Open
Methika1234 wants to merge 1 commit intob3-competition:mainfrom
Open
Implement complete task assignment API endpoints with Bruno tests#40Methika1234 wants to merge 1 commit intob3-competition:mainfrom
Methika1234 wants to merge 1 commit intob3-competition:mainfrom
Conversation
- Add POST /api/tasks to create tasks linking requests, assignees, and resources - Add GET /api/tasks to retrieve all tasks with summary information - Add GET /api/tasks/:taskId to fetch detailed task information - Add PUT /api/tasks/:taskId to update task status, notes, and attachments - Add comprehensive validation schemas for task endpoints - Create full Bruno test suite with end-to-end testing - Fix Firebase configuration and auth middleware for proper testing - All tests passing with real Firestore integration 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
prdai
requested changes
Jul 5, 2025
| const idToken = header.slice(7).trim(); | ||
|
|
||
| // For testing with test-token | ||
| if (idToken === 'test-token') { |
Contributor
There was a problem hiding this comment.
great idea! but i think we should have 2 seperate tokens for the 2 seperate roles, if we can have a test token creator sort of setup?
| const firestoreDB = admin.firestore(); | ||
| const realtimeDB = admin.database(); | ||
| const storageBucket = admin.storage().bucket(); | ||
| const storageBucket = process.env.FIREBASE_STORAGE_BUCKET ? admin.storage().bucket() : null; |
Contributor
There was a problem hiding this comment.
this feels like a odd setup, of us getting the env var or the admin storage bucket object, look into a better way to implement this please
Contributor
There was a problem hiding this comment.
i think we should start moving requestSchemas into separate files depending on the router
|
Stale pull request message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29