feat: add tag autocomplete functionality #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripariancommit
suggested changes
Jul 5, 2025
Contributor
ripariancommit
left a comment
ripariancommit
left a comment
There was a problem hiding this comment.
Overall endorsement from me! I was wondering if it was possible to use the tag autocomplete endpoint, and its cool to see that it is.
Replaces the initial implementation of the autocomplete feature with a reworked version based on reviewer feedback and upstream changes. Changes include: - Added autocomplete() method to the rule34Py class for tag suggestions based on partial input - Results are ordered by popularity and include Referer/Origin headers for compatibility - Refactored AutocompleteTag into a @DataClass for cleaner structure and type safety - Moved __autocomplete_url__ to api_urls.py - Reordered methods in rule34Py class alphabetically for consistency Also includes: - Comprehensive unit tests with recorded responses (R34_RECORD_RESPONSES=True) - Tests validate response types, attributes, and ordering of results This commit replaces the previous incomplete implementation and aligns with current codebase structure and standards.
reclacc
force-pushed
the
feature/autocomplete
branch
from
e5b6c32 to
18b1856
Compare
ripariancommit
approved these changes
Jul 26, 2025
Contributor
ripariancommit
left a comment
ripariancommit
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for adding a test.
reclacc
force-pushed
the
feature/autocomplete
branch
from
8bb271d to
ed3b353
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new autocomplete() method to rule34Py class that provides tag suggestions
based on partial input. Includes new AutocompleteTag class to represent
suggestion results and required API URL configuration.
Changes include:
Method returns suggestions ordered by popularity. Includes referer/origin
headers for compatibility.