Merged
Conversation
- remove redundant retry logic
…standard value sets
…er-package overrides
…set plugins - Implement comprehensive tests for the picklist plugin. - Create tests for the script plugin - Add tests for the standard value set plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces lifecycle hook support and significant improvements to version bumping and Git integration across the CLI and core packages. The changes enable per-package lifecycle hooks via a new
LifecycleEngine, improve theproject:version:bumpcommand to support org and Git-based diff strategies, and enhance theGitServicewith new utilities and cleaner initialization. Additionally, new exports and a utility for resolving hook configuration are added to the core package.Lifecycle hook integration:
LifecycleEnginesupport to thebuild,install, andvalidate-prcommands, allowing hooks fromsfpmConfig.hooksto be registered and executed during these operations. [1] [2] [3] [4] [5] [6] [7]Version bump command enhancements:
project:version:bumpto support new diff strategies: Git-based (using a newGitService.initialize) and org-based (fetches installed package versions from a target org), improving flexibility and accuracy of version updates. Improved error handling, output formatting, and code organization. [1] [2] [3] [4] [5]Core utilities and exports:
resolveHookConfig(with typeResolvedHookConfig) andisHookEnabledfor normalizing and checking per-package lifecycle hook configuration, and exported them from the core index. Also exported new org-related types. [1] [2] [3]GitService improvements:
GitServicefor cleaner imports, added agetChangedPackagePathsmethod to detect changed packages between refs, and improved temporary repository creation and initialization logic. [1] [2] [3] [4] [5]Lifecycle hook integration
LifecycleEnginewiring and hook registration tobuild,install, andvalidate-prcommands, enabling execution of lifecycle hooks fromsfpmConfig.hooks. [1] [2] [3] [4] [5] [6] [7]Version bump command enhancements
project:version:bumpto support org-based and Git-based diff strategies, improved error handling, and enhanced output formatting for updated and dependent packages. [1] [2] [3] [4] [5]Core utilities and exports
resolveHookConfig,isHookEnabled, andResolvedHookConfigfor per-package lifecycle hook configuration, and exported them along with new org types and lifecycle stage types. [1] [2] [3]GitService improvements
GitServicefor cleaner structure, addedgetChangedPackagePathsfor package diffing, and improved temporary repo handling and initialization. [1] [2] [3] [4] [5]