Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new artifact assembly system and improves version handling for Salesforce package artifacts. The main highlights are the addition of an
ArtifactAssemblerclass to manage artifact packaging, enhancements to version normalization for compatibility with semver, and updates to dependencies to support these features.Artifact Packaging and Management:
ArtifactAssemblerclass inartifact-assembler.tsthat orchestrates the process of assembling, metadata generation, changelog creation (with a stub provider), zipping, manifest updating, and symlinking for package artifacts. This provides a structured and extensible way to generate and manage package artifacts.ChangelogProviderinterface and implementation to allow for future extensibility in changelog generation.Version Handling Improvements:
normalizeVersionstatic method toVersionManagerthat converts Salesforce 4-part versions to semver-compatible formats and validates/coerces other version formats, improving reliability and compatibility.VersionTrackerto use the newnormalizeVersionmethod when setting new package versions, ensuring all versions are consistently formatted and valid.VersionManagerto ensurepackageDirectoriesare always treated as arrays when updating project definitions.Dependency Updates:
archiverand its type definitions topackage.jsonto enable artifact zipping functionality. [1] [2]Minor Fixes:
ArtifactServiceto referenceapiVersioninstead ofsourceVersion.