Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces several improvements and refactorings across the codebase, focusing on Apex parsing accuracy, code cleanup, TypeScript configuration, and developer experience. The most significant changes include refining the Apex parser to improve classification, removing legacy Git identity handling, updating TypeScript and test configurations, and enhancing documentation for both users and contributors.
Apex Parsing and Analysis Improvements:
ApexParserto provide more accurate and consistent classification of Apex classes, interfaces, triggers, and enums. Now returns a fully populatedApexClassInfoobject, initializes sensible defaults, and correctly handles theisTestproperty for all types. [1] [2] [3] [4] [5] [6] [7]ApexServiceto correctly filter and return class and test names using the improved parser output.ApexTypeAnalyzerandFHTAnalyzerto use the newSfpmMetadataPackagetype and improved method signatures for better type safety and clarity. [1] [2] [3]Git Handling and Cleanup:
GitIdentityclass and all related code, simplifying Git operations and reducing unnecessary environment variable dependencies. [1] [2] [3] [4] [5] [6].gitignoreto be cross-platform.TypeScript and Testing Configuration:
tsconfig.jsonto skip library checks and excludenode_modulesanddistdirectories, improving build performance and reducing noise.Documentation and Developer Experience:
README-DEV.mdwith an expandedREADME.mdthat includes project introduction, features, installation, usage, configuration, and contribution guidelines. Also adds an SVG logo for branding. [1] [2]Bug Fixes and Minor Improvements:
Projectcommand where package directories without apackageproperty are now safely skipped.commitIdproperties do not cause errors when creating artifacts.These changes collectively improve code quality, maintainability, and the overall developer experience.